-
Notifications
You must be signed in to change notification settings - Fork 8k
tests: stepper: minor fixes in drv84xx and stepper_shell #97408
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
jilaypandya
wants to merge
2
commits into
zephyrproject-rtos:main
Choose a base branch
from
jilaypandya:tests/stepper-various-minor-fixes
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
tests: stepper: minor fixes in drv84xx and stepper_shell #97408
jilaypandya
wants to merge
2
commits into
zephyrproject-rtos:main
from
jilaypandya:tests/stepper-various-minor-fixes
+19
−35
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
46973e5
to
de119c0
Compare
Looks good, but perhaps 2 commits are needed. |
- move drv84xx/emul tests to drv84xx - combine tests test_enable_gpios and test_enable_on_off_gpios - drop drv84xx_emul_before and drv84xx_emul_after Signed-off-by: Jilay Pandya <[email protected]>
…sync rename project from can_shell to stepper_shell drivers.stepper.shell_async is a relic of the past Signed-off-by: Jilay Pandya <[email protected]>
de119c0
to
67e85d9
Compare
done. |
jbehrensnx
approved these changes
Oct 13, 2025
|
dipakgmx
approved these changes
Oct 13, 2025
faxe1008
reviewed
Oct 14, 2025
cmake_minimum_required(VERSION 3.20.0) | ||
find_package(Zephyr REQUIRED HINTS $ENV{ZEPHYR_BASE}) | ||
project(can_shell) | ||
project(stepper_shell) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
whops, missed that one initially :^)
faxe1008
approved these changes
Oct 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.